Revert "Simplify auto_load_expand_dir_vars and remove substitute_path_component"
authorTom Tromey <tromey@adacore.com>
Fri, 14 Jul 2023 15:35:03 +0000 (09:35 -0600)
committerTom Tromey <tromey@adacore.com>
Fri, 14 Jul 2023 16:35:49 +0000 (10:35 -0600)
commit23e46b680f6fa6fce45aaf6c004cab6be322fbf1
treecf8d3151840382826cc547ba97f702f879f18fee
parent40e76c4db13274071540d35f3ee1815b90f814e7
Revert "Simplify auto_load_expand_dir_vars and remove substitute_path_component"

This reverts commit 02601231fdd91a7bd4837ce202906ea2ce661489.

This commit was a refactoring to remove an xrealloc and simplify
utils.[ch].  However, it has a flaw -- it mishandles a substitution
like "$datadir/subdir".

I am backing out the patch in the interests of fixing the regression
before GDB 14.  It can be reinstated (with modifications) later if we
like.

Regression tested on x86-64 Fedora 36.
gdb/Makefile.in
gdb/auto-load.c
gdb/unittests/utils-selftests.c [new file with mode: 0644]
gdb/utils.c
gdb/utils.h