Simplify saved_command_line handling
authorPedro Alves <palves@redhat.com>
Wed, 9 Mar 2016 18:25:00 +0000 (18:25 +0000)
committerPedro Alves <palves@redhat.com>
Wed, 9 Mar 2016 18:25:00 +0000 (18:25 +0000)
commit2669cade3dcebf5d572bcd535cf21934cbc1633c
tree4b4de5e2d89d3cf97ca0da1a53d4154ce9d7fa7b
parent187212b3c1aa55d9a5b544a6af3af0b5ce457403
Simplify saved_command_line handling

There doesn't seem to be much point in trying to reuse this buffer.
Prefer simplicity instead.

(In case you're wondering whether this fixes an off-by-one: linelength
is misnamed; it's really a size including terminating null char.)

gdb/ChangeLog:
2016-03-09  Pedro Alves  <palves@redhat.com>

* event-top.c (command_line_handler): Use xfree + xstrdup instead
of xrealloc + strcpy.
* main.c (captured_main): Use xstrdup instead of xmalloc plus
manual clear.
* top.c (saved_command_line): Rewrite comment.
(saved_command_line_size): Delete.
(command_line_input): Use xfree + xstrdup instead of xrealloc +
strcpy.
* top.h (saved_command_line_size): Delete declaration.
gdb/ChangeLog
gdb/event-top.c
gdb/main.c
gdb/top.c
gdb/top.h