PR middle-end/91582 - missing heap overflow detection for strcpy
authorMartin Sebor <msebor@redhat.com>
Thu, 5 Dec 2019 01:28:11 +0000 (01:28 +0000)
committerMartin Sebor <msebor@gcc.gnu.org>
Thu, 5 Dec 2019 01:28:11 +0000 (18:28 -0700)
commit268209f3a0dc07fcf13534610447ab732742eb2f
tree19c70c9ade74615720a40b206b35dcfc02c63f53
parenta59c50bd14f5bcb467a21ceb55f6b082510efc2f
PR middle-end/91582 - missing heap overflow detection for strcpy

gcc/ChangeLog:

PR middle-end/91582
* builtins.c (gimple_call_alloc_size): New function.
(compute_objsize): Add argument.  Call gimple_call_alloc_size.
Handle variable offsets and indices.
* builtins.h (gimple_call_alloc_size): Declare.
(compute_objsize): Add argument.
* gcc/gimple-ssa-warn-restrict.c: Remove assertions.
* tree-ssa-strlen.c (handle_store): Handle calls to allocated objects.

gcc/testsuite/ChangeLog:

PR middle-end/91582
* c-c++-common/Wstringop-truncation.c: Remove xfails.
* g++.dg/warn/Wstringop-overflow-4.C: New test.
* g++.dg/ext/attr-alloc_size.C: Suppress -Warray-bounds.
* gcc.dg/Warray-bounds-56.c: New test.
* gcc.dg/Wstringop-overflow-22.c: New test.
* gcc.dg/attr-alloc_size.c: Suppress -Warray-bounds.
* gcc.dg/attr-copy-2.c: Same.
* gcc.dg/builtin-stringop-chk-5.c: Remove xfails.
* gcc.dg/builtin-stringop-chk-8.c: Same.  Correct the text of expected
warnings.
* gcc.target/i386/pr82002-2a.c: Prune expected warning.
* gcc.target/i386/pr82002-2b.c: Same.

From-SVN: r278983
17 files changed:
gcc/ChangeLog
gcc/builtins.c
gcc/builtins.h
gcc/gimple-ssa-warn-restrict.c
gcc/testsuite/ChangeLog
gcc/testsuite/c-c++-common/Wstringop-truncation.c
gcc/testsuite/g++.dg/ext/attr-alloc_size.C
gcc/testsuite/g++.dg/warn/Wstringop-overflow-4.C [new file with mode: 0644]
gcc/testsuite/gcc.dg/Warray-bounds-56.c [new file with mode: 0644]
gcc/testsuite/gcc.dg/Wstringop-overflow-25.c [new file with mode: 0644]
gcc/testsuite/gcc.dg/attr-alloc_size.c
gcc/testsuite/gcc.dg/attr-copy-2.c
gcc/testsuite/gcc.dg/builtin-stringop-chk-5.c
gcc/testsuite/gcc.dg/builtin-stringop-chk-8.c
gcc/testsuite/gcc.target/i386/pr82002-2a.c
gcc/testsuite/gcc.target/i386/pr82002-2b.c
gcc/tree-ssa-strlen.c