gdb: optimize check for resumed threads with pending wait status in maybe_set_commit_...
authorSimon Marchi <simon.marchi@polymtl.ca>
Fri, 28 May 2021 04:33:35 +0000 (00:33 -0400)
committerSimon Marchi <simon.marchi@polymtl.ca>
Tue, 13 Jul 2021 00:46:53 +0000 (20:46 -0400)
commit273dadf2c20b93ef579367c42c255fcf4a3a2522
treed1870ed8113000565dc093003a46b7bc4182175c
parenta66f72981979a1bda60805b8554e0c78c4a39a21
gdb: optimize check for resumed threads with pending wait status in maybe_set_commit_resumed_all_targets

Consider a test case where many threads (thousands) keep hitting a
breakpoint whose condition evaluates to false.
maybe_set_commit_resumed_all_targets is called at each handled event,
when the scoped_disable_commit_resumed object in fetch_inferior_event is
reset_and_commit-ed.  One particularly expensive check in there is
whether the target has at least one resumed thread with a pending wait
status (in which case, we don't want to commit the resumed threads, as
we want to consume this status first).  It is currently implemented as
walking all threads of the target.

Since we now maintain a per-target list of resumed threads with pending
status, we can do this check efficiently, by checking whether that list
is empty or not.

Add the process_stratum_target::has_resumed_with_pending_wait_status
method for this, and use it in maybe_set_commit_resumed_all_targets.

Change-Id: Ia1595baa1b358338f94fc3cb3af7f27092dad5b6
gdb/infrun.c
gdb/process-stratum-target.h