cr16 disassembly error of disp20 fields
authorAlan Modra <amodra@gmail.com>
Sun, 30 Aug 2020 10:10:31 +0000 (19:40 +0930)
committerAlan Modra <amodra@gmail.com>
Sun, 30 Aug 2020 11:19:32 +0000 (20:49 +0930)
commit2781f857e6a654521f0decebb809989b72afa2c5
treece94a580e92857aa5a88e173b6a8088a0ae314d1
parentc930281005b0a01ab824864c231c19c297bfdda5
cr16 disassembly error of disp20 fields

When looking at the UB errors, I noticed that cbitb_test.d disassembly
wasn't reproducing the input assembly.  That turned out to be an error
in make_argument case arg_cr.  This fixes that and makes some general
tidies.

opcodes/
* cr16-dis.c: Formatting.
(parameter): Delete struct typedef.  Use dwordU instead
throughout file.
(make_argument <arg_idxr>): Simplify detection of cbitb, sbitb
and tbitb.
(make_argument <arg_cr>): Extract 20-bit field not 16-bit.
gas/
* testsuite/gas/cr16/cbitb_test.d: Update expected output.
* testsuite/gas/cr16/cbitw_test.d: Likewise.
* testsuite/gas/cr16/sbitb_test.d: Likewise.
* testsuite/gas/cr16/sbitw_test.d: Likewise.
* testsuite/gas/cr16/storb_test.d: Likewise.
* testsuite/gas/cr16/storw_test.d: Likewise.
* testsuite/gas/cr16/tbitb_test.d: Likewise.
* testsuite/gas/cr16/tbitw_test.d: Likewise.
gas/ChangeLog
gas/testsuite/gas/cr16/cbitb_test.d
gas/testsuite/gas/cr16/cbitw_test.d
gas/testsuite/gas/cr16/sbitb_test.d
gas/testsuite/gas/cr16/sbitw_test.d
gas/testsuite/gas/cr16/storb_test.d
gas/testsuite/gas/cr16/storw_test.d
gas/testsuite/gas/cr16/tbitb_test.d
gas/testsuite/gas/cr16/tbitw_test.d
opcodes/ChangeLog
opcodes/cr16-dis.c