base: Remove dubious/unused Flags functions
authorDaniel R. Carvalho <odanrc@yahoo.com.br>
Sat, 26 Dec 2020 14:31:03 +0000 (11:31 -0300)
committerDaniel Carvalho <odanrc@yahoo.com.br>
Tue, 19 Jan 2021 03:27:04 +0000 (03:27 +0000)
commit2aa5fb0d63ecc769085a7ebe9b1abda79668f5da
treef1d2090fcc06bd6103940de8bfc9d784b5bfde22
parente67b00710c0664e7b42fd3ea02e8f85adaf329b2
base: Remove dubious/unused Flags functions

The functions isSet(), noneSet(), and allSet() assume that
all bits of the underlying container have a corresponding
flag. This is typically not true, and the likelihood of
incorrectly using these functions is high.

Fortunately these functions are not being used anywhere,
and can be safely removed.

Alternatively, a mask could be provided on construction to
determine which bits of the underlying container correspond
to a flag bit, so that the proper bits are checked in these
functions.

Change-Id: Ia7cbfd0726943506a3f04dc417e67a0b57cdbf95
Signed-off-by: Daniel R. Carvalho <odanrc@yahoo.com.br>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/38736
Maintainer: Bobby R. Bruce <bbruce@ucdavis.edu>
Tested-by: kokoro <noreply+kokoro@google.com>
Reviewed-by: Jason Lowe-Power <power.jg@gmail.com>
Reviewed-by: Bobby R. Bruce <bbruce@ucdavis.edu>
src/base/flags.hh
src/base/flags.test.cc