gdbsupport: move xfree into its own file
authorAndrew Burgess <aburgess@redhat.com>
Mon, 8 Nov 2021 15:17:16 +0000 (15:17 +0000)
committerAndrew Burgess <aburgess@redhat.com>
Tue, 16 Nov 2021 17:45:44 +0000 (17:45 +0000)
commit2bb7589ddf61e163f2e414e7033fad56ea17e784
tree8b026bfba1304d7ea6460407593771a75a5c5309
parenta6e7fea128b8e1da3ea99dc906df56f85589d335
gdbsupport: move xfree into its own file

In the next commit I'd like to reference gdb_unique_ptr within the
common-utils.h file.  However, this requires that I include
gdb_unique_ptr.h, which requires that xfree be defined.

Interestingly, gdb_unique_ptr.h doesn't actually include anything that
defines xfree, but I was finding that when I added a gdb_unique_ptr.h
include to common-utils.h I was getting a dependency cycle; before my
change xfree was defined when gdb_unique_ptr.h was processed, while
after my change it was not, and this made g++ unhappy.

To break this cycle, I propose to move xfree into its own header file,
gdb-xfree.h, which I'll then include into gdb_unique_ptr.h and
common-utils.cc.
gdbsupport/common-utils.cc
gdbsupport/common-utils.h
gdbsupport/gdb-xfree.h [new file with mode: 0644]
gdbsupport/gdb_unique_ptr.h