Tighten check for whether sibcall references local variables
authorRichard Sandiford <richard.sandiford@arm.com>
Fri, 25 Nov 2016 08:17:46 +0000 (08:17 +0000)
committerRichard Sandiford <rsandifo@gcc.gnu.org>
Fri, 25 Nov 2016 08:17:46 +0000 (08:17 +0000)
commit2c28c3e49983e8054850e60704edc391146e376d
tree58fb86ed3f74b01d70b68acd8de7a8c9713e941b
parent4ae35e698893dcf2b11ab6fa7b39a9f5e0973cd8
Tighten check for whether sibcall references local variables

This loop:

      /* Make sure the tail invocation of this function does not refer
         to local variables.  */
      FOR_EACH_LOCAL_DECL (cfun, idx, var)
        {
          if (TREE_CODE (var) != PARM_DECL
              && auto_var_in_fn_p (var, cfun->decl)
              && (ref_maybe_used_by_stmt_p (call, var)
                  || call_may_clobber_ref_p (call, var)))
            return;
        }

triggered even for local variables that are passed by value.
This meant that we didn't allow local aggregates to be passed
to a sibling call but did (for example) allow global aggregates
to be passed.

I think the loop is really checking for indirect references,
so should be able to skip any variables that never have their
address taken.

gcc/
* tree-tailcall.c (find_tail_calls): Allow calls to reference
local variables if all references are known to be direct.

gcc/testsuite/
* gcc.dg/tree-ssa/tailcall-8.c: New test.

From-SVN: r242860
gcc/ChangeLog
gcc/testsuite/ChangeLog
gcc/testsuite/gcc.dg/tree-ssa/tailcall-8.c [new file with mode: 0644]
gcc/tree-tailcall.c