glsl: Only warn for macro names containing __
authorIan Romanick <ian.d.romanick@intel.com>
Tue, 18 Feb 2014 17:36:08 +0000 (09:36 -0800)
committerIan Romanick <ian.d.romanick@intel.com>
Wed, 19 Feb 2014 23:08:50 +0000 (15:08 -0800)
commit2c85fd5a964a78c9f7a93994fb79f1723c6f45b5
tree5c3a318c34435a92e7f35f10981fefabaed8ef1a
parent0bd78926304e72ef3566e977d0cb5a959d86b809
glsl: Only warn for macro names containing __

From page 14 (page 20 of the PDF) of the GLSL 1.10 spec:

    "In addition, all identifiers containing two consecutive underscores
     (__) are reserved as possible future keywords."

The intention is that names containing __ are reserved for internal use
by the implementation, and names prefixed with GL_ are reserved for use
by Khronos.  Names simply containing __ are dangerous to use, but should
be allowed.

Per the Khronos bug mentioned below, a future version of the GLSL
specification will clarify this.

Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
Cc: "9.2 10.0 10.1" <mesa-stable@lists.freedesktop.org>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Tested-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Anuj Phogat <anuj.phogat@gmail.com>
Tested-by: Darius Spitznagel <d.spitznagel@goodbytez.de>
Cc: Tapani Pälli <lemody@gmail.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=71870
Bugzilla: Khronos #11702
src/glsl/ast_to_hir.cpp