sim: Make Stats truly non-copy-constructible
authorRekai Gonzalez-Alberquilla <rekai.gonzalezalberquilla@arm.com>
Fri, 10 Feb 2017 17:27:33 +0000 (17:27 +0000)
committerGiacomo Travaglini <giacomo.travaglini@arm.com>
Tue, 13 Feb 2018 16:47:44 +0000 (16:47 +0000)
commit2d6afc6e2621fe67df09d4824ccd678a503b3517
treec714bc1bc2af3b25b266849c515855b36f1e334e
parente9f736738d61775cd3b739dbc9f85cbf4f4c135f
sim: Make Stats truly non-copy-constructible

The stats are silently non-copy constructible. Therefore, when someone
copy-constructs any object with stats, asserts happen when registering
the stats, as they were not constructed in the intended way.

This patch solves that by explicitly deleting the copy constructor,
trading an obscure run-time assert for a compile-time somehow more
meaningful error meassage.

This triggers some compilation errors as the FaultStats in the fault
definitions of ARM and SPARC use brace-enclosed initialisations in which
one of the elements derives from DataWrap, which is not
copy-constructible anymore. To fix that, this patch also adds a
constructor for the FaultVals in both ISAs.

Change-Id: I340e203b9386609b32c66e3b8918a015afe415a4
Reviewed-by: Curtis Dunham <curtis.dunham@arm.com>
Reviewed-by: Sascha Bischoff <sascha.bischoff@arm.com>
Reviewed-on: https://gem5-review.googlesource.com/8082
Reviewed-by: Jason Lowe-Power <jason@lowepower.com>
Reviewed-by: Andreas Sandberg <andreas.sandberg@arm.com>
Reviewed-by: Gabe Black <gabeblack@google.com>
Maintainer: Andreas Sandberg <andreas.sandberg@arm.com>
src/arch/arm/faults.cc
src/arch/arm/faults.hh
src/arch/sparc/faults.cc
src/arch/sparc/faults.hh
src/base/statistics.hh