python: Change || to && for MessageBuffers in connectPorts.
authorGabe Black <gabeblack@google.com>
Thu, 7 Mar 2019 04:43:59 +0000 (20:43 -0800)
committerGabe Black <gabeblack@google.com>
Mon, 18 Mar 2019 23:25:38 +0000 (23:25 +0000)
commit2da37b5efa70c34aa3665c947b0ef10c4e2a3ae7
treeb9454cf2e18c01be576b53716c7d9769ad90421d
parent7e38637c8dc1cff923c386e6ad74ceb9a1317ef2
python: Change || to && for MessageBuffers in connectPorts.

The connectPorts function currently checks if *either* of the peers in
a port connection are a MessageBuffer, and if so will ignore the
connection. This CL changes that || into a && so that *both* of the
peers need to be a Ruby types (either a MessageBuffer or Network) for
the connection to be ignored. That makes it easier to contain that
abnormal behavior to those types instead of having it apply even when
other types of port owners are involved.

Unfortunately the number of interesting Ruby types is unbounded, but
these are the types with ports as of today. This mechanism will
hopefully be replacedall together so this should be a temporary issue.

Change-Id: I140498770e5d37eb2abd3d99261d47e111f1c8ab
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/17031
Reviewed-by: Nikos Nikoleris <nikos.nikoleris@arm.com>
Reviewed-by: Jason Lowe-Power <jason@lowepower.com>
Reviewed-by: Andreas Sandberg <andreas.sandberg@arm.com>
Maintainer: Jason Lowe-Power <jason@lowepower.com>
src/python/pybind11/pyobject.cc