Properly handle dynamic reloc against normal symbol
authorH.J. Lu <hjl.tools@gmail.com>
Tue, 12 Apr 2016 02:41:37 +0000 (19:41 -0700)
committerH.J. Lu <hjl.tools@gmail.com>
Tue, 12 Apr 2016 02:41:52 +0000 (19:41 -0700)
commit2df3368d851b653880c2e3312c99eb8adf89f3db
treeedbac9980b980c6c5bc58b15de92312e73d2f2d4
parentb545ef977bd39f4351172ab73f5d7cc2508944ec
Properly handle dynamic reloc against normal symbol

We shouldn't issue an error for read-only segment with dynamic IFUNC
relocations when dynamic relocations are against normal symbols.

bfd/

PR ld/19939
* elf-bfd.h (_bfd_elf_allocate_ifunc_dyn_relocs): Add a pointer
to bfd_boolean.
* elf-ifunc.c (_bfd_elf_allocate_ifunc_dyn_relocs): Updated.
Set *readonly_dynrelocs_against_ifunc_p to TRUE if dynamic reloc
applies to read-only section.
* elf32-i386.c (elf_i386_link_hash_table): Add
readonly_dynrelocs_against_ifunc.
(elf_i386_allocate_dynrelocs): Updated.
(elf_i386_size_dynamic_sections): Issue an error for read-only
segment with dynamic IFUNC relocations only if
readonly_dynrelocs_against_ifunc is TRUE.
* elf64-x86-64.c (elf_x86_64_link_hash_table): Add
readonly_dynrelocs_against_ifunc.
(elf_x86_64_allocate_dynrelocs): Updated.
(elf_x86_64_size_dynamic_sections): Issue an error for read-only
segment with dynamic IFUNC relocations only if
readonly_dynrelocs_against_ifunc is TRUE.
* elfnn-aarch64.c (elfNN_aarch64_allocate_ifunc_dynrelocs):
Updated.

ld/

PR ld/19939
* testsuite/ld-i386/i386.exp: Run PR ld/19939 tests.
* testsuite/ld-x86-64/x86-64.exp: Likewise.
* testsuite/ld-i386/pr19939.s: New file.
* testsuite/ld-i386/pr19939a.d: Likewise.
* testsuite/ld-i386/pr19939b.d: Likewise.
* testsuite/ld-x86-64/pr19939.s: Likewise.
* testsuite/ld-x86-64/pr19939a.d: Likewise.
* testsuite/ld-x86-64/pr19939b.d: Likewise.
15 files changed:
bfd/ChangeLog
bfd/elf-bfd.h
bfd/elf-ifunc.c
bfd/elf32-i386.c
bfd/elf64-x86-64.c
bfd/elfnn-aarch64.c
ld/ChangeLog
ld/testsuite/ld-i386/i386.exp
ld/testsuite/ld-i386/pr19939.s [new file with mode: 0644]
ld/testsuite/ld-i386/pr19939a.d [new file with mode: 0644]
ld/testsuite/ld-i386/pr19939b.d [new file with mode: 0644]
ld/testsuite/ld-x86-64/pr19939.s [new file with mode: 0644]
ld/testsuite/ld-x86-64/pr19939a.d [new file with mode: 0644]
ld/testsuite/ld-x86-64/pr19939b.d [new file with mode: 0644]
ld/testsuite/ld-x86-64/x86-64.exp