Remove stale -DNO_PROTOTYPES bits from gdb testsuite
authorPedro Alves <palves@redhat.com>
Fri, 3 Jul 2020 12:34:22 +0000 (13:34 +0100)
committerPedro Alves <palves@redhat.com>
Fri, 3 Jul 2020 13:58:20 +0000 (14:58 +0100)
commit2eb821570037e8836d61ab3dcb9331c21f8a64d9
tree47c3fc7b3beecb00174c8d0d4770589e65b71ca6
parent9adda7af10c354a62146d917a30a2fae8df370d1
Remove stale -DNO_PROTOTYPES bits from gdb testsuite

The gdb.base/call-sc.exp, gdb.base/structs.exp and
gdb.base/structs2.exp testcases still try compiling the sources with
-DNO_PROTOTYPES, but the corresponding sources don't have any #ifdef
NO_PROTOTYPES any longer.  Those were removed throughout years ago.

OTOH, gdb.base/ovlymgr.h does check for NO_PROTOTYPES, but no .exp
file compiles it with -DNO_PROTOTYPES.

gdb.base/reread.exp and gdb.base/varargs.exp set a 'prototypes'
global, which is a stale bit left behind when the "try-compiling
without and then with -DNO_PROTOTYPES" logic was around.

gdb/testsuite/ChangeLog:

* gdb.base/call-sc.exp (start_scalars_test): Use
prepare_for_testing and don't try compiling with -DNO_PROTOTYPES.
* gdb.base/overlays.c: Remove references to PARAMS.
* gdb.base/ovlymgr.h (PARAMS): Delete, and remove all references.
* gdb.base/reread.exp: Don't set 'prototypes' global.
* gdb.base/structs.exp (start_structs_test): Use
prepare_for_testing and don't try compiling with -DNO_PROTOTYPES.
* gdb.base/structs2.exp: Don't set 'prototypes' global.  Use
prepare_for_testing and don't try compiling with -DNO_PROTOTYPES.
Don't issue "set width 0".  Remove gdb_stop_suppressing_tests
call.
* gdb.base/varargs.exp: Don't set 'prototypes' global.
gdb/testsuite/ChangeLog
gdb/testsuite/gdb.base/call-sc.exp
gdb/testsuite/gdb.base/overlays.c
gdb/testsuite/gdb.base/ovlymgr.h
gdb/testsuite/gdb.base/reread.exp
gdb/testsuite/gdb.base/structs.exp
gdb/testsuite/gdb.base/structs2.exp
gdb/testsuite/gdb.base/varargs.exp