i965/vec4: check opcode on vec4_instruction::reads_flag(channel)
authorAlejandro Piñeiro <apinheiro@igalia.com>
Fri, 23 Oct 2015 13:32:30 +0000 (15:32 +0200)
committerAlejandro Piñeiro <apinheiro@igalia.com>
Fri, 23 Oct 2015 16:11:09 +0000 (18:11 +0200)
commit2f1bc1da864f8d169427b911bf60e1023321e420
tree57d4f0d353024aecf07f0f991bd64c7c5b6d8e5d
parentfb064901e9bd83a63d486f246b9ea943cd00f6cd
i965/vec4: check opcode on vec4_instruction::reads_flag(channel)

Commit f17b78 added an alternative reads_flag(channel) that returned
if the instruction was reading a specific channel flag. By mistake it
only took into account the predicate, but when the opcode is
VS_OPCODE_UNPACK_FLAGS_SIMD4X2 there isn't any predicate, but the flag
are used.

That mistake caused some regressions on old hw. More information on
this bug:
https://bugs.freedesktop.org/show_bug.cgi?id=92621

Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
src/mesa/drivers/dri/i965/brw_ir_vec4.h