Report early wakeup of condition_variable::wait_until as no_timeout
authorMike Crowe <mac@mcrowe.com>
Wed, 1 Aug 2018 15:39:45 +0000 (15:39 +0000)
committerJonathan Wakely <redi@gcc.gnu.org>
Wed, 1 Aug 2018 15:39:45 +0000 (16:39 +0100)
commit2f5934326542b3f303db91cc4cd432cd488f0258
tree1d909cf9f46064af55af5dae9bb10e0263463b8c
parent5534096c09d8d8bc4e12b73d1db179ccd7c60671
Report early wakeup of condition_variable::wait_until as no_timeout

As currently implemented, condition_variable always ultimately waits
against std::chrono::system_clock. This clock can be changed in arbitrary
ways by the user which may result in us waking up too early or too late
when measured against the caller-supplied clock.

We can't (yet) do much about waking up too late (PR 41861), but
if we wake up too early we must return cv_status::no_timeout to indicate a
spurious wakeup rather than incorrectly returning cv_status::timeout.

2018-08-01  Mike Crowe  <mac@mcrowe.com>

* include/std/condition_variable (wait_until): Only report timeout
if we really have timed out when measured against the
caller-supplied clock.
* testsuite/30_threads/condition_variable/members/2.cc: Add test
case to confirm above behaviour.

From-SVN: r263224
libstdc++-v3/ChangeLog
libstdc++-v3/include/std/condition_variable
libstdc++-v3/testsuite/30_threads/condition_variable/members/2.cc