vc4: Declare the cpu pointers as being modified in NEON asm.
authorCarsten Haitzler (Rasterman) <raster@rasterman.com>
Tue, 8 Jan 2019 16:28:30 +0000 (16:28 +0000)
committerEric Anholt <eric@anholt.net>
Tue, 29 Jan 2019 00:45:45 +0000 (16:45 -0800)
commit300d3ae8b1445b5060f92c77c0f577f4b7b2c7d6
tree9f0a9536356509d419c393adc4712d3413d1ea63
parent522f68847152e9111def094f7fb35b44f3d0fc80
vc4: Declare the cpu pointers as being modified in NEON asm.

Otherwise, the compiler is free to reuse the register containing the input
for another call and assume that the value hasn't been modified.  Fixes
crashes on texture upload/download with current gcc.

We now have to have a temporary for the cpu2 value, since outputs must be
lvalues.

(commit message by anholt)

Fixes: 4d30024238ef ("vc4: Use NEON to speed up utile loads on Pi2.")
src/broadcom/common/v3d_cpu_tiling.h