compiler: fix evaluation order of LHS index expressions
authorIan Lance Taylor <ian@gcc.gnu.org>
Wed, 11 Jul 2018 14:22:12 +0000 (14:22 +0000)
committerIan Lance Taylor <ian@gcc.gnu.org>
Wed, 11 Jul 2018 14:22:12 +0000 (14:22 +0000)
commit305130b92e1a785d89178ce6334ead38e975268f
treebda3b9e97b0fab2129706a037775832f83e6982f
parent2bae8b2fadab13b6f886829f782e4d5cffdfafd6
compiler: fix evaluation order of LHS index expressions

    The spec says that when an index expression appears on the left hand
    side of an assignment, the operands should be evaluated. The
    gofrontend code was assuming that that only referred to the index
    operand. But discussion of https://golang.org/issue/23188 has
    clarified that this means both the slice/map/string operand and the
    index operand. Adjust the gofrontend code accordingly.

    Fixes golang/go#23188

    Reviewed-on: https://go-review.googlesource.com/123155

From-SVN: r262554
gcc/go/gofrontend/MERGE
gcc/go/gofrontend/expressions.cc
gcc/go/gofrontend/expressions.h