Remove cleanup from frame_prepare_for_sniffer
authorTom Tromey <tom@tromey.com>
Sun, 8 Oct 2017 18:40:07 +0000 (12:40 -0600)
committerTom Tromey <tom@tromey.com>
Mon, 9 Oct 2017 05:16:42 +0000 (23:16 -0600)
commit30a9c02feff56bd58a276c2a7262f364baa558ac
tree653735bbd531718449106195009cede65ffa1a0b
parent757325a3f24e01bf8e7b7214f33c546bc52d1d12
Remove cleanup from frame_prepare_for_sniffer

Currently frame_prepare_for_sniffer returns a cleanup.  This patch
changes it to return void, and exposes frame_cleanup_after_sniffer to
the caller.

Normally I would write an RAII class for this sort of thing; but
because there was just a single caller of frame_prepare_for_sniffer,
and because this caller is already using try/catch, I thought it
seemed ok to require explicit calls in this instance.

Regression tested by the buildbot.

gdb/ChangeLog
2017-10-08  Tom Tromey  <tom@tromey.com>

* frame-unwind.c (frame_unwind_try_unwinder): Update.
* frame.h (frame_cleanup_after_sniffer): Declare.
(frame_prepare_for_sniffer): Return void.
* frame.c (frame_cleanup_after_sniffer): No longer static.  Change
type of argument.
(frame_prepare_for_sniffer): Return void.
gdb/ChangeLog
gdb/frame-unwind.c
gdb/frame.c
gdb/frame.h