Restore previous sigmask in gdb.block_signals
authorTom Tromey <tromey@adacore.com>
Fri, 28 Jul 2023 18:02:38 +0000 (12:02 -0600)
committerTom Tromey <tromey@adacore.com>
Mon, 31 Jul 2023 12:35:32 +0000 (06:35 -0600)
commit30c01bb104e4dfc50e8cf3d0312bbf7d22f73d10
treef906d765c5224c1d8a24bccd2649a99ced0bde2f
parent55b1edf5994a09be98d45a598d9bb721222b88d0
Restore previous sigmask in gdb.block_signals

Tom de Vries found a bug where, sometimes, a SIGCHLD would be
delivered to a non-main thread, wreaking havoc.

The problem is that gdb.block_signals after first blocking a set of
signals, then unblocked the same set rather than restoring the initial
situation.  This function being called from the DAP thread lead to
SIGCHLD being unblocked there.

This patch fixes the problem by restoring the previous set of signals
instead.

Tested-by: Tom de Vries <tdevries@suse.de>
Reviewed-By: Tom de Vries <tdevries@suse.de>
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30680
gdb/python/lib/gdb/__init__.py