Fix crash in -stack-list-arguments
authorTom Tromey <tromey@adacore.com>
Wed, 22 Jul 2020 18:28:33 +0000 (12:28 -0600)
committerTom Tromey <tromey@adacore.com>
Wed, 22 Jul 2020 18:28:33 +0000 (12:28 -0600)
commit32fa152e3bfcf021ce49767be547fae5129d922b
tree23436ea92981455106cfe719460d2bd0674a67df
parent8c419a91d761989b824d1bbe3b4575068317181e
Fix crash in -stack-list-arguments

-stack-list-arguments will crash when stopped in an Ada procedure that
has an argument with a certain name ("_objectO" -- which can only be
generated by the compiler).  The bug occurs because lookup_symbol will
fail in this case.

This patch changes -stack-list-arguments to mirror what is done with
arguments elsewhere.  (As an aside, I don't understand why this lookup
is even needed, but I assume it is some stabs thing?)

In the longer term I think it would be good to share this code between
MI and the CLI.  However, due to the upcoming release, I preferred a
more local fix.

gdb/ChangeLog
2020-07-22  Tom Tromey  <tromey@adacore.com>

* mi/mi-cmd-stack.c (list_args_or_locals): Use
lookup_symbol_search_name.

gdb/testsuite/ChangeLog
2020-07-22  Tom Tromey  <tromey@adacore.com>

* gdb.ada/mi_prot.exp: New file.
* gdb.ada/mi_prot/pkg.adb: New file.
* gdb.ada/mi_prot/pkg.ads: New file.
* gdb.ada/mi_prot/prot.adb: New file.
gdb/ChangeLog
gdb/mi/mi-cmd-stack.c
gdb/testsuite/ChangeLog
gdb/testsuite/gdb.ada/mi_prot.exp [new file with mode: 0644]
gdb/testsuite/gdb.ada/mi_prot/pkg.adb [new file with mode: 0644]
gdb/testsuite/gdb.ada/mi_prot/pkg.ads [new file with mode: 0644]
gdb/testsuite/gdb.ada/mi_prot/prot.adb [new file with mode: 0644]