zink: add lengthy comment and remove assert from discard_if ntv pass
authorMike Blumenkrantz <michael.blumenkrantz@gmail.com>
Sun, 14 Jun 2020 21:24:29 +0000 (17:24 -0400)
committerMarge Bot <eric+marge@anholt.net>
Mon, 13 Jul 2020 21:13:45 +0000 (21:13 +0000)
commit359c9384837f332edb3140f43675c761341b8bcd
treeda754dc5bf00ed8de94992af992919b83a153979
parent97ec109d8fa07c02531c9f54b7edf7085d6130bf
zink: add lengthy comment and remove assert from discard_if ntv pass

as in the comment, while we may want to try verifying that discard will be
the last instruction in a block, it's a bit problematic given that other nir
passes we're doing may insert instructions after a discard as part of e.g.,
nir_opt_dead_cf in the process of removing another block

fixes shaders@glsl-fs-discard-04

Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5852>
src/gallium/drivers/zink/zink_compiler.c