svga: tweak pre-VGPU10 rasterization offsets
authorBrian Paul <brianp@vmware.com>
Fri, 18 Aug 2017 20:38:03 +0000 (14:38 -0600)
committerBrian Paul <brianp@vmware.com>
Tue, 3 Oct 2017 18:07:05 +0000 (12:07 -0600)
commit362fb05b65ce7db69af6ae896caa2f0f6afd5fb2
treefca17f0da306179e863694464f717ad24a0200ce
parent3e39abf6a033cccbf2bbf85bf23785b7367cdcef
svga: tweak pre-VGPU10 rasterization offsets

It seems there's no perfect x/y biases for line drawing to satisfy all
applications.  Depending on the biases, either real apps produce results
similar to VGPU10 while Piglit's gl-1.0-ortho-pos fails, or vice versa.

Let's lean toward real applications (Solidworks, SolidEdge, Google Earth)
over Piglit.

Using (-0.5, -0.5) for points, lines and triangles, seems to generally
work well.

We don't seem to have these issues with VGPU10.

Tested with Piglit and CAD-oriented apitraces.  See VMware bugs 1775498
and 1905053.

Reviewed-by: José Fonseca <jfonseca@vmware.com>
Reviewed-by: Charmaine Lee <charmainel@vmware.com>
src/gallium/drivers/svga/svga_state_framebuffer.c