rpm: really take DEPENDENCIES into account
authorThomas Petazzoni <thomas.petazzoni@bootlin.com>
Mon, 19 Nov 2018 11:19:45 +0000 (12:19 +0100)
committerPeter Korsgaard <peter@korsgaard.com>
Mon, 19 Nov 2018 15:06:12 +0000 (16:06 +0100)
commit36385f87f38e5efd9d678ce10d59bfe442277eb9
tree6c3c15d62f26f6a19fd9d29fb6909be96a7e6645
parent906903ce4a87a57d028cce7edf62b58648d8bb72
rpm: really take DEPENDENCIES into account

Commit e7af4033c32560594ddbd457b68f6d3713662a26 ("rpm: use the new
gettext logic") introduced a really nasty bug: by adding
$(TARGET_NLS_DEPENDENCIES) to RPM_DEPENDENCIES, it completely
overwrote the existing value of RPM_DEPENDENCIES, entirely masking all
mandatory RPM dependencies.

rpm is fairly towards the end of the alphabet, and most other
mandatory dependencies (berkeleydb, host-pkgconf, file and popt)
appear earlier by alphabetic ordering. Only zlib was afterwards, but
since file depends on zlib, it was always built before. This probably
explains why our autobuilders haven't encountered a single build
failure.

However, a simple "make rpm" clearly exhibits the failure, and
obviously the upcoming per-package folder mechanism makes such bugs
even more obvious.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
package/rpm/rpm.mk