arch-gcn3: fix bits that SDWA selects
authorMatt Sinclair <Matthew.Sinclair@amd.com>
Thu, 3 May 2018 22:14:03 +0000 (18:14 -0400)
committerAnthony Gutierrez <anthony.gutierrez@amd.com>
Mon, 13 Jul 2020 16:19:47 +0000 (16:19 +0000)
commit3846e907374307e869312b022c26ba3ddf551b42
treed1788f6c888301e78d117ce7ea76ebf2d759a717
parentecd1e05f5725832c2d5dfdc53f4c4100bf763284
arch-gcn3: fix bits that SDWA selects

This commit fixes a bug in 200f2408 where the SDWA support was selecting bits
backwards.  As part of this commit, to help resolve this problem in the
future, I have added asserts in the helper functions in bitfield.hh to ensure
that the number of bits aren't negative.

Change-Id: I4b0ecb0e7c110600c0b5063101b75f9adcc512ac
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/29931
Tested-by: kokoro <noreply+kokoro@google.com>
Reviewed-by: Anthony Gutierrez <anthony.gutierrez@amd.com>
Reviewed-by: Matt Sinclair <mattdsinclair@gmail.com>
Maintainer: Anthony Gutierrez <anthony.gutierrez@amd.com>
src/arch/gcn3/insts/inst_util.hh
src/base/bitfield.hh