match.pd: Avoid ICE with shifts [PR97979]
authorJakub Jelinek <jakub@redhat.com>
Thu, 26 Nov 2020 09:50:23 +0000 (10:50 +0100)
committerJakub Jelinek <jakub@redhat.com>
Thu, 26 Nov 2020 09:50:23 +0000 (10:50 +0100)
commit39f5e9aded23e8b7e0e7080fc6020478b9c5b7b5
tree78e54cc7831648237feab7f647b73b7bdc8d9fef
parent776a37f6ac5682dae9a1ef07bc04570ea80f42ca
match.pd: Avoid ICE with shifts [PR97979]

My recent wide_int_binop changes caused ICE on this testcase.
The problem is that for shift where amount has MSB set now fails to optimize
into a constant (IMHO we should treat out of bounds shifts the same later),
but there is a precedent for that already - e.g. division by zero fails
to optimize into a constant too.  I think it is better if path isolation
checks for these UBs and does something the user chooses (__builtin_trap vs.
__builtin_unreachable, and either a deferred warning about the UB or
nothing).
This patch just doesn't optimize if int_const_binop failed.

2020-11-26  Jakub Jelinek  <jakub@redhat.com>

PR tree-optimization/97979
* match.pd ((X {&,^,|} C2) << C1 into (X << C1) {&,^,|} (C2 << C1)):
Only optimize if int_const_binop returned non-NULL.

* gcc.dg/pr97979.c: New test.
* gcc.c-torture/compile/pr97979.c: New test.
gcc/match.pd
gcc/testsuite/gcc.c-torture/compile/pr97979.c [new file with mode: 0644]
gcc/testsuite/gcc.dg/pr97979.c [new file with mode: 0644]