sim,gpu: Make ioctl unconditionally take an address parameter.
authorGabe Black <gabeblack@google.com>
Sat, 7 Dec 2019 11:43:46 +0000 (03:43 -0800)
committerGabe Black <gabeblack@google.com>
Thu, 12 Mar 2020 07:21:13 +0000 (07:21 +0000)
commit3b98e65eaf2f1216085f4ec5013a1fd881618cb1
tree2914ae4510b7c42fee77503e80031867642fbc4b
parentb2625d0b03d375085fb1989fa95871255850c7d4
sim,gpu: Make ioctl unconditionally take an address parameter.

The definition of ioctl is not actually variadic, it just doesn't
specify what the type of the pointer is that it takes as its third
argument. The man page says that that's because it predates void *
being valid C.

By passing this address around (even if it's unused), we avoid having
to extract system call arguments further down the call stack.

Change-Id: I62541237baafaec30bbe3df06b3284dd286a4051
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/23456
Tested-by: kokoro <noreply+kokoro@google.com>
Reviewed-by: Bobby R. Bruce <bbruce@ucdavis.edu>
Maintainer: Gabe Black <gabeblack@google.com>
src/gpu-compute/cl_driver.cc
src/gpu-compute/cl_driver.hh
src/sim/emul_driver.hh
src/sim/syscall_emul.hh