Fix two buglets in cp_print_value_fields patch
authorTom Tromey <tromey@adacore.com>
Tue, 18 Jun 2019 15:37:02 +0000 (09:37 -0600)
committerTom Tromey <tromey@adacore.com>
Thu, 27 Jun 2019 13:51:52 +0000 (07:51 -0600)
commit3d507ff23b724ecb2b9a5a61cebd0fba275cfbc3
treebb0d15d697c09452f1b885b9ad2a07878f1f89b4
parentba85f98c42877287f45644a6d75513239c9490a5
Fix two buglets in cp_print_value_fields patch

Pedro and Tom both pointed out issues in the cp_print_value_fields
patch, aka the fix for PR c++/20020.

This patch addresses both issues.  Tested on x86-64 Fedora 29.

gdb/ChangeLog
2019-06-27  Tom Tromey  <tromey@adacore.com>

* cp-valprint.c (cp_print_value_fields): Pass opts, not options,
to cp_print_static_field.

gdb/testsuite/ChangeLog
2019-06-27  Tom Tromey  <tromey@adacore.com>

* gdb.cp/constexpr-field.exp: Use setup_xfail.
gdb/ChangeLog
gdb/cp-valprint.c
gdb/testsuite/ChangeLog
gdb/testsuite/gdb.cp/constexpr-field.exp