Remove a cleanup from parse_expression_for_completion
authorTom Tromey <tom@tromey.com>
Fri, 16 Feb 2018 05:41:03 +0000 (22:41 -0700)
committerTom Tromey <tom@tromey.com>
Wed, 21 Feb 2018 16:09:45 +0000 (09:09 -0700)
commit3eac2b654808f9e233885f910045eea9d2ca0aa0
tree22d3276e46df79ab5506979101b94ee6ecdfb12e
parent6ccb583f751e020a6db768d517c2dd3ba6d93cc4
Remove a cleanup from parse_expression_for_completion

This removes a cleanup from parse_expression_for_completion, by
changing various expression-completion functions to use
gdb::unique_xmalloc_ptry rather than explicit malloc+free.

Regression tested by the buildbot.

gdb/ChangeLog
2018-02-21  Tom Tromey  <tom@tromey.com>

* value.h: (extract_field_op): Update.
* eval.c (extract_field_op): Return a const char *.
* expression.h (parse_expression_for_completion): Update.
* completer.c (complete_expression): Update.
(add_struct_fields): Make fieldname const.
* parse.c (expout_completion_name): Now a unique_xmalloc_ptr.
(mark_completion_tag, parse_exp_in_context_1): Update.
(parse_expression_for_completion): Change "name" to
unique_xmalloc_ptr*.
gdb/ChangeLog
gdb/completer.c
gdb/eval.c
gdb/expression.h
gdb/parse.c
gdb/value.h