Fix problem where version script causes predefined hidden symbol to be defined twice.
authorCary Coutant <ccoutant@gmail.com>
Thu, 22 Dec 2016 01:32:39 +0000 (17:32 -0800)
committerCary Coutant <ccoutant@gmail.com>
Fri, 23 Dec 2016 00:00:06 +0000 (16:00 -0800)
commit40d7d93ff412f4c34cde3daa04890d5cd2e0d9c9
tree0f063eb01c597b5b10b609e1caee825945c01acc
parentce0db13751aed2782c417bc4cf715313f9273e94
Fix problem where version script causes predefined hidden symbol to be defined twice.

When creating a predefined hidden symbol like _GLOBAL_OFFSET_TABLE_, gold
was incorrectly letting a version script add a version to the symbol,
resulting in two copies of the symbol, both STB_LOCAL, but one of which
was grouped in the globals part of the symbol table.

gold/
* symtab.cc (Symbol_table::define_special_symbol): Add is_forced_local
parameter; if set, do not check version script.
(Symbol_table::do_define_in_output_data): Pass is_forced_local for
STB_LOCAL predefined symbols.
(Symbol_table::do_define_in_output_segment): Likewise.
(Symbol_table::do_define_in_output_segment): Likewise.
(Symbol_table::do_define_as_constant): Likewise.
* symtab.h (Symbol_table::define_special_symbol): Add is_forced_local
parameter. Adjust all callers.
* testsuite/Makefile.am (ver_test_8.sh): New test case.
* testsuite/Makefile.in: Regenerate.
* ver_test_8.sh: New test script.
gold/ChangeLog
gold/symtab.cc
gold/symtab.h
gold/testsuite/Makefile.am
gold/testsuite/Makefile.in
gold/testsuite/ver_test_8.sh [new file with mode: 0755]