Eliminate target_fileio_open_warn_if_slow
authorPedro Alves <palves@redhat.com>
Tue, 19 May 2020 17:36:24 +0000 (18:36 +0100)
committerPedro Alves <palves@redhat.com>
Tue, 19 May 2020 17:36:51 +0000 (18:36 +0100)
commit4111f652f955028e8219fad2d60af1fd22aa29ee
treed50f5be0ada132550b4096402f2afbf560f17430
parentad80db5b9f7c95105c78d3ab439678184d1b7177
Eliminate target_fileio_open_warn_if_slow

This basically makes target_fileio_open_1 extern, renamed to
target_fileio_open, and eliminates the current
target_fileio_open_warn_if_slow and target_fileio_open.

A following parameter will want to change gdb_bfd_iovec_fileio_open,
the only caller of target_fileio_open_warn_if_slow, to pass down
"warn_if_slow" true/false from the caller, instead of hardcoding
"warn_if_slow" true.

gdb/ChangeLog:
2020-05-19  Pedro Alves  <palves@redhat.com>

* gdb_bfd.c (gdb_bfd_iovec_fileio_open): Adjust.
* target.c (target_fileio_open_1): Rename to target_fileio_open
and make extern.  Use bool.
(target_fileio_open, target_fileio_open_warn_if_slow): Delete.
(target_fileio_read_alloc_1): Adjust.
* target.h (target_fileio_open): Add 'warn_if_slow' parameter.
(target_fileio_open_warn_if_slow): Delete declaration.
gdb/ChangeLog
gdb/gdb_bfd.c
gdb/target.c
gdb/target.h