Don't check HAVE_UNISTD_H
authorTom Tromey <tom@tromey.com>
Wed, 26 Sep 2018 11:28:07 +0000 (05:28 -0600)
committerTom Tromey <tom@tromey.com>
Mon, 1 Oct 2018 08:58:23 +0000 (02:58 -0600)
commit4176f14d9c9e509425bffc01404c751e238b1f01
tree52d0fe01cad44b8950278103ad719603b3837139
parenta95746f91769c0f65e9393ff83aad0871d1a666b
Don't check HAVE_UNISTD_H

I noticed some spots that were checking HAVE_UNISTD_H.  There is no
need to do this, as <unistd.h> is unconditionally included in many
places in gdb.  This sort of cleanup was done once before, in 2013:

    2013-07-01  Pedro Alves  <palves@redhat.com>

    * defs.h: Don't check HAVE_UNISTD_H before including <unistd.h>.
    (STDIN_FILENO, STDOUT_FILENO, STDERR_FILENO): Delete.
    * tracepoint.c: Don't check HAVE_UNISTD_H before including
    <unistd.h>.

HAVE_UNISTD_H seems to come from gnulib, so there are still mentions
of it in the source.

gdb/ChangeLog
2018-10-01  Tom Tromey  <tom@tromey.com>

* unittests/scoped_mmap-selftests.c: Don't check HAVE_UNISTD_H.
* unittests/scoped_fd-selftests.c: Don't check HAVE_UNISTD_H.
* common/scoped_fd.h: Don't check HAVE_UNISTD_H.
gdb/ChangeLog
gdb/common/scoped_fd.h
gdb/unittests/scoped_fd-selftests.c
gdb/unittests/scoped_mmap-selftests.c