glsl/linker: simplify xfb_offset vs xfb_stride overflow check
authorAndres Gomez <agomez@igalia.com>
Fri, 18 Jan 2019 16:33:10 +0000 (18:33 +0200)
committerAndres Gomez <agomez@igalia.com>
Tue, 19 Mar 2019 15:23:27 +0000 (17:23 +0200)
commit422882e78f2cf0ab69ff4a58f3c9465fcb5fef0d
tree1e276af8afa632dfb01f7e519c351c32507a6f85
parent3be05dd2679b2525ff80bac715d6ea097295c9ea
glsl/linker: simplify xfb_offset vs xfb_stride overflow check

Current implementation uses a complicated calculation which relies in
an implicit conversion to check the integral part of 2 division
results.

However, the calculation actually checks that the xfb_offset is
smaller or a multiplier of the xfb_stride. For example, while this is
expected to fail, it actually succeeds:

  "

    ...

    layout(xfb_buffer = 2, xfb_stride = 12) out block3 {
      layout(xfb_offset = 0) vec3 c;
      layout(xfb_offset = 12) vec3 d; // ERROR, requires stride of 24
    };

    ...

  "

Fixes: 2fab85aaea5 ("glsl: add xfb_stride link time validation")
Cc: Timothy Arceri <tarceri@itsqueeze.com>
Signed-off-by: Andres Gomez <agomez@igalia.com>
Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com>
src/compiler/glsl/link_varyings.cpp