glsl: link error if unsized array not-last in ssbo
authorJose Maria Casanova Crespo <jmcasanova@igalia.com>
Fri, 17 Feb 2017 13:06:46 +0000 (14:06 +0100)
committerAndres Gomez <agomez@igalia.com>
Fri, 17 Feb 2017 13:49:16 +0000 (15:49 +0200)
commit429f112a1124ace20052f0ea52de691edbfddf03
treed29c0898caa0f959fca561c2111f609cd68dbff5
parenta0ac118398c924f2ae75e5649fbaacd95abd231f
glsl: link error if unsized array not-last in ssbo

If an unsized declared array is not the last in an SSBO
and an implicit size can not be defined on linking time,
the linker should raise an error instead of reaching
an assertion on GL.

This reverts part of commit 3da08e166415a745139c1127040a24e8a45dc553
getting back to the behavior of commit 5b2675093e863a52b610f112884ae12d42513770

The original patch was correct for GLES that should produce
a compile-time error but the linker error is still necessary
in desktop GL.

Fixes the following piglit tests:
tests/spec/arb_shader_storage_buffer_object/non_integral_size_array_member.shader_test
tests/spec/arb_shader_storage_buffer_object/unsized_array_member.shader_test

Reviewed-by: Dave Airlie <airlied@redhat.com>
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Signed-off-by: Jose Maria Casanova Crespo <jmcasanova@igalia.com>
src/compiler/glsl/link_uniform_blocks.cpp