glsl: Remove bogus check on return value of link_uniform_blocks().
authorPaul Berry <stereotype441@gmail.com>
Sat, 27 Jul 2013 22:07:08 +0000 (15:07 -0700)
committerPaul Berry <stereotype441@gmail.com>
Tue, 30 Jul 2013 17:10:25 +0000 (10:10 -0700)
commit4682b9b7bfffff0caa7bd0f6af3ae820a1df08af
tree37c796fc53cf5dee267d446090e0d6c508e2a04d
parent4f8048bb5a8558ae4313b12ffd70b593cc629fe8
glsl: Remove bogus check on return value of link_uniform_blocks().

A comment in link_intrastage_shaders(), and an if-test that followed
it, seemed to indicate that link_uniform_blocks() would return a
negative value in the event of an error.  But this is not the
case--all error checking has already been performed by
validate_intrastage_interface_blocks(), and link_uniform_blocks() can
only return unsigned values.

So get rid of the if-test and change the return type of
link_intrastage_shaders() to clarify that it can only return unsigned
values.

Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
src/glsl/link_uniform_blocks.cpp
src/glsl/linker.cpp
src/glsl/linker.h