radv: only inject implicit subpass dependencies if necessary
authorSamuel Pitoiset <samuel.pitoiset@gmail.com>
Tue, 17 Mar 2020 08:45:50 +0000 (09:45 +0100)
committerSamuel Pitoiset <samuel.pitoiset@gmail.com>
Tue, 17 Mar 2020 12:24:36 +0000 (13:24 +0100)
commit46e8ba1344e840f9406537ae73c841a357278924
tree404e4e4967591ffd870aa859795f53ce54ac8c28
parenta0591863db891fd39bdbae199f740b0d4b5f0173
radv: only inject implicit subpass dependencies if necessary

The Vulkan 1.2.134 spec update clarified when implicit subpass
dependencies should be injected by the driver. They only make
sense if automatic layout transitions are performed.

This should fix a performance regression with RPCS3 (although
they added a workaround for RADV since the regression has been found).

Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2502
Fixes: e60de085473 ("radv: handle missing implicit subpass dependencies")
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4210>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4210>
src/amd/vulkan/radv_pass.c