intel/fs: Fix FB write inst groups
authorJason Ekstrand <jason@jlekstrand.net>
Mon, 2 Sep 2019 02:57:05 +0000 (21:57 -0500)
committerJason Ekstrand <jason@jlekstrand.net>
Fri, 6 Sep 2019 03:58:09 +0000 (03:58 +0000)
commit47e974354715702a75ad2f1ee803b72cbd8cc9f1
treee1c8118e357985b79e8f5ad78119eadbceeb0419
parentaa77fc309a87bc263ebacaa9c69cd623ba5c7e23
intel/fs: Fix FB write inst groups

This commit does two things.  First, it simplifies the way we compute
the FB write group bit.  There's no reason to use a ternary because
inst->group / 16 can only be 0 or 1.  Second, it fixes an order-of-
operations bug where the ternary wasn't selecting between (1 << 11) and
0 but between (1 << 11) and 0 | brw_dp_write_desc(...).

Fixes: 0d9648416 "intel/compiler: Use generic SEND for Gen7+ FB writes"
Reviewed-by: Francisco Jerez <currojerez@riseup.net>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
src/intel/compiler/brw_fs.cpp