Simplify uses of thread_to_thread_object
authorTom Tromey <tom@tromey.com>
Sun, 16 Sep 2018 14:02:22 +0000 (08:02 -0600)
committerTom Tromey <tom@tromey.com>
Mon, 17 Sep 2018 05:36:54 +0000 (23:36 -0600)
commit4a137fec2e1a8a6372da8fca1040ee582c62f78d
tree6b99d8cbfba9349e6018200496fbf3d6b515e91c
parent8ff03f0bfbf0dc7d125f6ea0b844636c0aba74f6
Simplify uses of thread_to_thread_object

An review by Simon of an earlier showed a few spots related to
thread_to_thread_object that could be simplified.  This also detected
a latent bug, where thread_to_thread_object was inconsistent about
setting the Python exception before a NULL return.

Tested on x86-64 Fedora 28.

gdb/ChangeLog
2018-09-16  Tom Tromey  <tom@tromey.com>

* python/py-threadevent.c (py_get_event_thread): Simplify.
* python/py-inferior.c (infpy_thread_from_thread_handle):
Return immediately after calling thread_to_thread_object.  Use
Py_RETURN_NONE.
(thread_to_thread_object): Set the exception on a NULL return.
gdb/ChangeLog
gdb/python/py-inferior.c
gdb/python/py-threadevent.c