misc: Generalize GDB single stepping.
authorGabe Black <gabeblack@google.com>
Sat, 6 Dec 2014 06:37:03 +0000 (22:37 -0800)
committerGabe Black <gabeblack@google.com>
Sat, 6 Dec 2014 06:37:03 +0000 (22:37 -0800)
commit4a8a0a07982b7896127d0cb723fde08b3825bb48
tree32274c02ae9dca6d6ebad156e559c9afcc44cabb
parentfb07d43b1a4a903fb2e51b41685eb5814d9f9e11
misc: Generalize GDB single stepping.

The new single stepping implementation for x86 doesn't rely on any ISA
specific properties or functionality. This change pulls out the per ISA
implementation of those functions and promotes the X86 implementation to the
base class.

One drawback of that implementation is that the CPU might stop on an
instruction twice if it's affected by both breakpoints and single stepping.
While that might be a little surprising, it's harmless and would only happen
under somewhat unlikely circumstances.
13 files changed:
src/arch/alpha/remote_gdb.cc
src/arch/alpha/remote_gdb.hh
src/arch/arm/remote_gdb.cc
src/arch/arm/remote_gdb.hh
src/arch/mips/remote_gdb.cc
src/arch/mips/remote_gdb.hh
src/arch/power/remote_gdb.hh
src/arch/sparc/remote_gdb.cc
src/arch/sparc/remote_gdb.hh
src/arch/x86/remote_gdb.cc
src/arch/x86/remote_gdb.hh
src/base/remote_gdb.cc
src/base/remote_gdb.hh