Revert "i965/fs: Predicate byte scattered writes if needed"
authorFrancisco Jerez <currojerez@riseup.net>
Sun, 25 Feb 2018 00:05:21 +0000 (16:05 -0800)
committerFrancisco Jerez <currojerez@riseup.net>
Fri, 2 Mar 2018 19:28:56 +0000 (11:28 -0800)
commit4b4838b1ae46a0ce9fed88f275cc01167302cf24
tree7c2feba5f25d0d122658ef01f2d362c42931c7b0
parentc063e88909e630bb4605037eb0fc072f40f8c2a2
Revert "i965/fs: Predicate byte scattered writes if needed"

This reverts commit a4031bdfa927fb4c3c5d0bdadc70634f3c1a5eac.  It's
redundant with the sample mask predication done at this point by the
common logical send lowering infrastructure, and rather buggy because
it wasn't applying the correct sample mask in shaders using discard,
since the dispatch mask returned by FS_OPCODE_MOV_DISPATCH_TO_FLAGS
doesn't reflect samples discarded by the shader, so it could have led
to data corruption in fragment shader invocations that execute discard
based on a non-dynamically uniform condition.

Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
src/intel/compiler/brw_fs_nir.cpp