Fix regression caused by minimal symbol changes
authorTom Tromey <tromey@adacore.com>
Mon, 18 Mar 2019 15:32:09 +0000 (09:32 -0600)
committerTom Tromey <tromey@adacore.com>
Mon, 18 Mar 2019 15:56:27 +0000 (09:56 -0600)
commit4bd56d18cc9799f283715a96ba61fd4b958b2f71
treeb1c1e25361965fffc8cfa5d9cda69215168ecce1
parent55c10aca2e93cc7a4301aa1635ef9d6d73a804b1
Fix regression caused by minimal symbol changes

The earlier patch to change minimal symbol allocations to use xmalloc
erroneously left a call to obstack_blank in
minimal_symbol_reader::install.  Because obstack_blank does not finish
the object allocation on an obstack, this in turn could cause invalid
memory reads in some situations.

This patch fixes the problem by removing the call.  Tested on x86-64
Fedora 29; also verified with valgrind.

gdb/ChangeLog
2019-03-18  Tom Tromey  <tromey@adacore.com>

* minsyms.c (minimal_symbol_reader::install): Remove call to
obstack_blank.
gdb/ChangeLog
gdb/minsyms.c