Restore behavior of disabling address randomization by default on GDBserver
authorSimon Marchi <simon.marchi@ericsson.com>
Wed, 22 Aug 2018 17:37:05 +0000 (13:37 -0400)
committerSimon Marchi <simon.marchi@ericsson.com>
Wed, 22 Aug 2018 17:37:05 +0000 (13:37 -0400)
commit4e2aa472847923f94b99f138d7fc4c77796f8239
tree981d3b2b5d321219adb48ebbade2d93f36672cde
parent9eef0608951ba0e551dd6dd079ce1e20bae11f6b
Restore behavior of disabling address randomization by default on GDBserver

Commit

  c12a508 ("Add client_state struct.")

inadvertently changed the default behavior of GDBserver wrt address
randomization.  The old disable_randomization global variable was
initialized to 1, whereas the corresponding field in the client_state
structure is initialized to 0.

This fixes

  make check TESTS="gdb.base/jit-simple.exp" RUNTESTFLAGS="--target_board=native-gdbserver"
  make check TESTS="gdb.base/execl-update-breakpoints.exp" RUNTESTFLAGS="--target_board=native-gdbserver"

Note that the execl-update-breakpoints.exp would only fail on systems
where the toolchain emits position-independent executables by default
(otherwise the main executable position is never randomized, so the
value of disable_randomization didn't matter).

gdb/gdbserver/ChangeLog:

PR gdb/23374
PR gdb/23375
* server.h (struct client_state) <disable_randomization>:
Initialize to 1.
gdb/gdbserver/ChangeLog
gdb/gdbserver/server.h