stor-layout: Reject forming arrays with elt sizes not divisible by elt alignment...
authorJakub Jelinek <jakub@redhat.com>
Fri, 23 Oct 2020 08:05:17 +0000 (10:05 +0200)
committerJakub Jelinek <jakub@redhat.com>
Fri, 23 Oct 2020 08:07:36 +0000 (10:07 +0200)
commit50bc94898fac1bd9cc1dabf227208fb5d369c4c4
tree7ccaf2d4c1433f2f01582bc64ffcbd1c7675c640
parent5f966d689710cbb03a0592504102119ab99978d4
stor-layout: Reject forming arrays with elt sizes not divisible by elt alignment [PR97164]

As mentioned in the PR, since 2005 we reject if array elements are smaller
than their alignment (i.e. overaligned elements), because such arrays don't
make much sense, only their first element is guaranteed to be aligned as
user requested, but the next element can't be.
The following testcases show something we've been silent about but is
equally bad, the 2005 case is just the most common special case of that
the array element size is not divisible by the alignment.  In those arrays
too only the first element is guaranteed to be properly aligned and the
second one can't be.

This patch rejects those cases too, but keeps the existing wording for the
old common case.

Unfortunately, the patch breaks bootstrap, because libbid uses this mess
(forms arrays with 24 byte long elements with 16 byte element alignment).
I don't really see justification for that, so I've decreased the alignment
to 8 bytes instead.

2020-10-23  Jakub Jelinek  <jakub@redhat.com>

PR tree-optimization/97164
gcc/
* stor-layout.c (layout_type): Also reject arrays where element size
is constant, but not a multiple of element alignment.
gcc/testsuite/
* c-c++-common/pr97164.c: New test.
* gcc.c-torture/execute/pr36093.c: Move ...
* gcc.dg/pr36093.c: ... here.  Add dg-do compile and dg-error
directives.
* gcc.c-torture/execute/pr43783.c: Move ...
* gcc.dg/pr43783.c: ... here.  Add dg-do compile, dg-options and
dg-error directives.
libgcc/config/libbid/
* bid_functions.h (UINT192): Decrease alignment to 8 bytes.
gcc/stor-layout.c
gcc/testsuite/c-c++-common/pr97164.c [new file with mode: 0644]
gcc/testsuite/gcc.c-torture/execute/pr36093.c [deleted file]
gcc/testsuite/gcc.c-torture/execute/pr43783.c [deleted file]
gcc/testsuite/gcc.dg/pr36093.c [new file with mode: 0644]
gcc/testsuite/gcc.dg/pr43783.c [new file with mode: 0644]
libgcc/config/libbid/bid_functions.h