arch-arm: Report real instruction encoding when Undefined
authorGiacomo Travaglini <giacomo.travaglini@arm.com>
Wed, 13 Feb 2019 15:14:34 +0000 (15:14 +0000)
committerGiacomo Travaglini <giacomo.travaglini@arm.com>
Mon, 29 Apr 2019 08:49:25 +0000 (08:49 +0000)
commit529284becb4610016bdea7a5a40d1be73e2ec697
treecf44884be90c9fde6409bed9aa50a492011889b9
parent9305bb6e83d57fde96c78e7b11d50914935f57d5
arch-arm: Report real instruction encoding when Undefined

When dumping the opcode that caused an Undefined Instruction, we just
want to dump the real instruction encoding, and not the extended version
with metabits (like thumb, bigThumb etc). This was not appening when
panicking in SE mode.

The patch is also replacing custom masking in the Unknown(64) disassembler
in favour of ArmStaticInstruction::encoding() helper.

Change-Id: I9eb6fd145d02b4b07bb51f0bd89ca014d6d5a6de
Signed-off-by: Giacomo Travaglini <giacomo.travaglini@arm.com>
Reviewed-by: Andreas Sandberg <andreas.sandberg@arm.com>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/18395
Maintainer: Andreas Sandberg <andreas.sandberg@arm.com>
Tested-by: kokoro <noreply+kokoro@google.com>
src/arch/arm/faults.cc
src/arch/arm/insts/misc.cc
src/arch/arm/insts/misc64.cc