i965: Don't overwrite the math function with conditional mod.
authorMatt Turner <mattst88@gmail.com>
Fri, 21 Nov 2014 20:20:53 +0000 (12:20 -0800)
committerMatt Turner <mattst88@gmail.com>
Mon, 24 Nov 2014 22:07:32 +0000 (14:07 -0800)
commit56ac25918aea37a3c2c52f99fc285f2475be9128
tree9fa9acd724f26135013cc9e7d0674e0200d0d9cd
parentf5bef2d2e53fc43cbdf15914e8886fc51f77b546
i965: Don't overwrite the math function with conditional mod.

Ben was asking about the undocumented restriction that the math
instruction cannot use the dependency control hints. I went to reconfirm
and disabled the is_math() check in opt_set_dependency_control() and saw
that the disassembled math instructions with dependency hints had a
bogus math function. We were mistakenly overwriting it by setting an
empty conditional mod.

Unfortunately, this wasn't the cause of the aforementioned problem (I
reproduced it). This bug is benign, since we don't set dependeny hints
on math instructions -- but maybe some day.

Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
src/mesa/drivers/dri/i965/brw_fs_generator.cpp
src/mesa/drivers/dri/i965/brw_vec4_generator.cpp