combine: Punt on out of range rotate counts [PR93505]
authorJakub Jelinek <jakub@redhat.com>
Thu, 30 Jan 2020 20:28:17 +0000 (21:28 +0100)
committerJakub Jelinek <jakub@redhat.com>
Thu, 30 Jan 2020 20:28:17 +0000 (21:28 +0100)
commit56b92750f83724177d2c6eae30c208e935a56a37
tree4442d994ad2a140f6904ede7a42d02c80a07ddcc
parent4dd468a042e19ef0fdbb1c53ca4060d4cb4972c5
combine: Punt on out of range rotate counts [PR93505]

What happens on this testcase is with the out of bounds rotate we get:
Trying 13 -> 16:
   13: r129:SI=r132:DI#0<-<0x20
      REG_DEAD r132:DI
   16: r123:DI=r129:SI<0
      REG_DEAD r129:SI
Successfully matched this instruction:
(set (reg/v:DI 123 [ <retval> ])
    (const_int 0 [0]))
during combine.  So, perhaps we could also change simplify-rtx.c to punt
if it is out of bounds rather than trying to optimize anything.
Or, but probably GCC11 material, if we decide that ROTATE/ROTATERT doesn't
have out of bounds counts or introduce targetm.rotate_truncation_mask,
we should truncate the argument instead of punting.
Punting is better for backports though.

2020-01-30  Jakub Jelinek  <jakub@redhat.com>

PR middle-end/93505
* combine.c (simplify_comparison) <case ROTATE>: Punt on out of range
rotate counts.

* gcc.c-torture/compile/pr93505.c: New test.
gcc/ChangeLog
gcc/combine.c
gcc/testsuite/ChangeLog
gcc/testsuite/gcc.c-torture/compile/pr93505.c [new file with mode: 0644]