gdb: handle relative paths to DWO files
authorCaroline Tice <cmtice@google.com>
Wed, 17 Mar 2021 22:54:22 +0000 (22:54 +0000)
committerAndrew Burgess <andrew.burgess@embecosm.com>
Wed, 7 Apr 2021 10:41:50 +0000 (11:41 +0100)
commit56d467f4ee376e28a16740f26e5f6eec3c743632
treec72b27cb14e1b66aaa598392f8463777fecaacbf
parent61dee7220ecff488f24d32511c2532466d25741f
gdb: handle relative paths to DWO files

DWARF allows .dwo file paths to be relative rather than absolute.

When they are relative, DWARF uses DW_AT_comp_dir to find the .dwo
file.  DW_AT_comp_dir can also be relative, making the entire search
patch for the .dwo file relative.

In this case, GDB currently searches relative to its current working
directory, i.e. the directory from which the debugger was launched,
but not relative to the directory containing the built binary.  This
cannot be right, as the compiler, when generating the relative paths,
knows where it's building the binary but can have no idea where the
debugger will be launched.

The correct thing is to add the directory containing the binary to the
search paths used for resolving relative locations of dwo files. That
is what this patch does.

gdb/ChangeLog:

* dwarf2/read.c (try_open_dwop_file): Add path for the binary to
the search paths used resolve relative location of .dwo file.

gdb/testsuite/ChangeLog:

* gdb.dwarf2/fission-relative-dwo.c: New file.
* gdb.dwarf2/fission-relative-dwo.exp: New file.
gdb/ChangeLog
gdb/dwarf2/read.c
gdb/testsuite/ChangeLog
gdb/testsuite/gdb.dwarf2/fission-relative-dwo.c [new file with mode: 0644]
gdb/testsuite/gdb.dwarf2/fission-relative-dwo.exp [new file with mode: 0644]