intel/compiler: don't use byte operands for src1 on ICL
authorLionel Landwerlin <lionel.g.landwerlin@intel.com>
Wed, 19 Jun 2019 12:09:35 +0000 (05:09 -0700)
committerLionel Landwerlin <lionel.g.landwerlin@intel.com>
Sat, 29 Jun 2019 12:56:09 +0000 (12:56 +0000)
commit5847de6e9afe12bd29ad694a76860a0575ab4747
treeb8d3bc45fb4d11a7e87191f0ab54e1796b5d6008
parent500b45a98a6183ff8ab7bae77e0a750a3cd45adc
intel/compiler: don't use byte operands for src1 on ICL

The simulator complains about using byte operands, we also have
documentation telling us.

Note that add operations on bytes seems to work fine on HW (like ADD).
Using dwords operands with CMP & SEL fixes the following tests :

   dEQP-VK.spirv_assembly.type.vec*.i8.*

v2: Drop the GLK changes (Matt)
    Add validator tests (Matt)

v3: Drop GLK ref (Matt)
    Don't mix float/integer in MAD (Matt)

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Rafael Antognolli <rafael.antognolli@intel.com> (v1)
Reviewed-by: Matt Turner <mattst88@gmail.com>
BSpec: 3017
Cc: <mesa-stable@lists.freedesktop.org>
src/intel/compiler/brw_eu_validate.c
src/intel/compiler/brw_fs_builder.h
src/intel/compiler/brw_fs_nir.cpp
src/intel/compiler/test_eu_validate.cpp