[gdb/exp] Fix UB in scalar_binop
authorTom de Vries <tdevries@suse.de>
Mon, 23 May 2022 12:50:02 +0000 (14:50 +0200)
committerTom de Vries <tdevries@suse.de>
Mon, 23 May 2022 12:50:02 +0000 (14:50 +0200)
commit5a3cf18c2ed9593f194ea22f50ea5651532f6cfc
tree4b617189ef5761bb5f892e09774bedf49865dc52
parent05527d8ca1082b4607e9ddc3209691f454b3b186
[gdb/exp] Fix UB in scalar_binop

When building gdb with -fsanitize=undefined, I run into:
...
$ gdb -q -batch -ex "p -(-0x7fffffffffffffff - 1)"
src/gdb/valarith.c:1385:10: runtime error: signed integer overflow: \
  0 - -9223372036854775808 cannot be represented in type 'long int'
$1 = -9223372036854775808
...

Fix this by performing the substraction in scalar_binop using unsigned types.

Tested on x86_64-linux.
gdb/testsuite/gdb.base/arithmet.exp
gdb/valarith.c