More fixes for buffer overruns instigated by corrupt binaries.
authorNick Clifton <nickc@redhat.com>
Mon, 3 Nov 2014 17:44:00 +0000 (17:44 +0000)
committerNick Clifton <nickc@redhat.com>
Mon, 3 Nov 2014 17:44:00 +0000 (17:44 +0000)
commit5a3f568b70bdfb91aacdfb66657b56d8c6d242f1
treed11c8695362d773082a427bb3897d598a1ba0998
parentba241f2d5a6f1ac57e746d230892e27a70def4a6
More fixes for buffer overruns instigated by corrupt binaries.

PR binutils/17512
* objdump.c (slurp_symtab): Fail gracefully if the table could not
be read.
(dump_relocs_in_section): Likewise.

* aoutx.h (slurp_symbol_table): Check that computed table size is
not bigger than the file from which is it being read.
(slurp_reloc_table): Likewise.
* coffcode.h (coff_slurp_line_table): Remove unneeded local
'warned'.  Do not try to print the details of a symbol with an
invalid index.
* coffgen.c (make_a_sectiobn_from_file): Check computed string
index against length of string table.
(bfd_coff_internal_syment_name): Check read in string offset
against length of string table.
(build_debug_section): Return a pointer to the section used.
(_bfd_coff_read_string_table): Store the length of the string
table in the coff_tdata structure.
(bfd_coff_free_symbols): Set the length of the string table to
zero when it is freed.
(coff_get_normalized_symtab): Check offsets against string table
or data table lengths as appropriate.
* cofflink.c (_bfd_coff_link_input_bfd): Check offset against
length of string table.
* compress.c (bfd_get_full_section_contents): Check computed size
against the size of the file.
* libcoff-in.h (obj_coff_strings_len): Define.
(struct coff_tdata): Add strings_len field.
* libcoff.h: Regenerate.
* peXXigen.c (pe_print_debugdata): Do not attempt to print the
data if the debug section is too small.
* xcofflink.c (xcoff_link_input_bfd):  Check offset against
length of string table.
12 files changed:
bfd/ChangeLog
bfd/aoutx.h
bfd/coffcode.h
bfd/coffgen.c
bfd/cofflink.c
bfd/compress.c
bfd/libcoff-in.h
bfd/libcoff.h
bfd/peXXigen.c
bfd/xcofflink.c
binutils/ChangeLog
binutils/objdump.c