glsl: non-last member unsized array on SSBO must fail compilation on GLSL ES 3.1
authorJose Maria Casanova Crespo <jmcasanova@igalia.com>
Fri, 10 Feb 2017 13:25:27 +0000 (14:25 +0100)
committerKenneth Graunke <kenneth@whitecape.org>
Sat, 11 Feb 2017 07:14:12 +0000 (23:14 -0800)
commit5bc222ebafddd14f2329f5096287b51d798a6431
treed77d5a91a24ce86cc6be8d7600c804e6e5e09ff1
parent0514b0bdc91e34509f09c27cecc3c3d323967f13
glsl: non-last member unsized array on SSBO must fail compilation on GLSL ES 3.1

From GLSL ES 3.10 spec, section 4.1.9 "Arrays":

"If an array is declared as the last member of a shader storage block
 and the size is not specified at compile-time, it is sized at run-time.
 In all other cases, arrays are sized only at compile-time."

In desktop GLSL it is allowed to have unsized-arrays that are
not last, as long as we can determine that they are implicitly
sized, which is detected at link-time.

With this patch Mesa reports a compilation error as glslang does with
the following shader:

buffer SSBO { vec4 data[]; vec4 moreData;};
void main (void)
{
}

Fixes:
dEQP-GLES31.functional.debug.negative_coverage.log.shader.compile_compute_shader
dEQP-GLES31.functional.debug.negative_coverage.callbacks.shader.compile_compute_shader
dEQP-GLES31.functional.debug.negative_coverage.get_error.shader.compile_compute_shader

Cc: "17.0" <mesa-stable@lists.freedesktop.org>
Signed-off-by: Jose Maria Casanova Crespo <jmcasanova@igalia.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
src/compiler/glsl/ast_to_hir.cpp